Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing metrics unit when available #15

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

olegbespalov
Copy link
Collaborator

What?

Start passing metric units when it's available

Why?

It's part of the standard.

case metrics.Time:
return "ms"
case metrics.Data:
return "By"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return "By"
return "byte"

Is it on purpose?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's by purpose. OpenTelemetry follows the UCCM standard where bytes is By see open-telemetry/opentelemetry-specification#2973

@olegbespalov olegbespalov requested a review from codebien June 19, 2024 07:28
@olegbespalov olegbespalov merged commit 2ff1f89 into main Jun 19, 2024
10 checks passed
@olegbespalov olegbespalov deleted the feat/metric-units branch June 19, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants